Add static factory methods to ApiGatewayRequestIdentity and AwsProxyRequestContext#1496
Open
Add static factory methods to ApiGatewayRequestIdentity and AwsProxyRequestContext#1496
Conversation
|
Can somebody please review and approve it? A lot of boilerplate code needs to be written otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
issue #1495
Description of changes:
This PR resolves issue #1495 by implementing static factory methods for both
ApiGatewayRequestIdentityandAwsProxyRequestContextclasses.Implemented Changes
Added
getApiGatewayRequestIdentity()toApiGatewayRequestIdentityclass:Added
getApiGatewayRequestIdentity(String sourceIp)toApiGatewayRequestIdentityclass:Added
getAwsProxyRequestContext()toAwsProxyRequestContextclass:Added
getAwsProxyRequestContext(String httpMethod)toAwsProxyRequestContextclass:Benefits
Questions for Maintainers
getAwsProxyRequestContext()andgetApiGatewayRequestIdentity()preferred, or would you prefer a different naming pattern likebuilder()orof()?I've tested these changes locally and they work as expected.
By submitting this pull request